Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parsing metric.metadata from OTLP JSON #10026

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

dashpole
Copy link
Contributor

Description

Follow-up to #10006, which added metric.metadata to pmetric.

I forgot to add support for parsing the field from JSON in that PR. This PR adds the missing support.

Testing

Unit tests

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.56%. Comparing base (326ef7c) to head (c5949c0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10026   +/-   ##
=======================================
  Coverage   91.55%   91.56%           
=======================================
  Files         360      360           
  Lines       16693    16698    +5     
=======================================
+ Hits        15284    15289    +5     
  Misses       1073     1073           
  Partials      336      336           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dashpole dashpole force-pushed the json_metric_metadata branch 4 times, most recently from ef1ab4b to 54509f4 Compare April 25, 2024 15:05
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dashpole

@codeboten codeboten merged commit 31528ce into open-telemetry:main Apr 26, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 26, 2024
andrzej-stencel pushed a commit to andrzej-stencel/opentelemetry-collector that referenced this pull request May 27, 2024
Follow-up to
open-telemetry#10006,
which added metric.metadata to pmetric.

I forgot to add support for parsing the field from JSON in that PR. This
PR adds the missing support.

#### Testing

Unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants