[processorhelper] use mdatagen level and noop meter #10235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows components to set the minimum level needed for them to produce telemetry. By default, this is set to configtelemetryLevelBasic. If the telemetry level is below that minimum level, then the noop meter is used for metrics. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This cleans up the need to have a level in the ObsReport struct. Added test to validate the change as none existed before Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10235 +/- ##
==========================================
+ Coverage 92.47% 92.50% +0.02%
==========================================
Files 387 387
Lines 18252 18242 -10
==========================================
- Hits 16879 16874 -5
+ Misses 1027 1023 -4
+ Partials 346 345 -1 ☔ View full report in Codecov by Sentry. |
TylerHelmuth
approved these changes
May 29, 2024
TylerHelmuth
added
the
Skip Changelog
steves-canva
pushed a commit
to Canva/opentelemetry-collector
that referenced
this pull request
Jun 14, 2024
…0235) This cleans up the need to have a level in the ObsReport struct. Added test to validate the change as none existed before --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the need to have a level in the ObsReport struct. Added test to validate the change as none existed before