[exporter/debug] format spans as one-liners in normal verbosity
#10280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an initial barebones implementation that only outputs the span's name, trace ID and span ID. Other useful fields like duration etc. can be added in follow-up enhancements.
This was referenced May 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10280 +/- ##
==========================================
+ Coverage 92.36% 92.46% +0.09%
==========================================
Files 387 390 +3
Lines 18435 18461 +26
==========================================
+ Hits 17028 17070 +42
+ Misses 1053 1036 -17
- Partials 354 355 +1 ☔ View full report in Codecov by Sentry. |
mx-psi
reviewed
Jun 3, 2024
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
mx-psi
approved these changes
Jun 5, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
mx-psi
added a commit
that referenced
this pull request
Jun 21, 2024
…ty (#10225) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Changes the behavior of `normal` verbosity of the Debug exporter for logs to display each log record in one line of text. Note that if the body of the log record contains newlines, the output will be displayed in multiple lines. This pull request is part of #7806; it implements the change for logs. The changes for metrics and [traces](#10280) will be proposed in separate pull requests. The implementation in this pull request does not display any details on the resource or the scope of the logs. I would like to propose displaying the resource and the scope as separate lines in a separate pull request. This change applies to the Debug exporter only. The behavior of the Logging exporter remains unchanged. To use this behavior, switch from the deprecated Logging exporter to Debug exporter. #### Link to tracking issue - #7806 #### Testing Added unit tests for the formatter. #### Documentation Described the formatting in the Debug exporter's README. --------- Co-authored-by: Roger Coll <roger.coll@elastic.co> Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
…al-verbosity-traces
|
Looks like you need to do |
andrzej-stencel
commented
Jun 21, 2024
| // writeAttributes returns a slice of strings in the form "attrKey=attrValue" | ||
| func writeAttributes(attributes pcommon.Map) (attributeStrings []string) { | ||
| attributes.Range(func(k string, v pcommon.Value) bool { | ||
| attribute := fmt.Sprintf("%s=%s", k, v.AsString()) |
There was a problem hiding this comment.
I think I could rewrite writeAttributes to take buffer and use buffer.WriteString instead of fmt.Sprintf if that helps? Perhaps as a follow-up improvement PR?
There was a problem hiding this comment.
Yeah that makes sense, fine for me to do this on a follow up PR
mx-psi
pushed a commit
that referenced
this pull request
Jun 24, 2024
…verbosity (#10462) #### Description This pull request is part of #7806; it implements the change for metrics. The changes for [logs](#10225) and [traces](#10280) have been proposed in separate pull requests. This change applies to the Debug exporter only. The behavior of the Logging exporter remains unchanged. To use this behavior, switch from the deprecated Logging exporter to Debug exporter. #### Link to tracking issue - #7806 #### Testing Added unit tests for the formatter. #### Documentation Described the formatting in the Debug exporter's README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an initial barebones implementation that only outputs the span's name, trace ID and span ID. Other useful fields like duration etc. can be added in follow-up enhancements.
This pull request is part of #7806; it implements the change for traces. The changes for logs and metrics are proposed in separate pull requests.
This change applies to the Debug exporter only. The behavior of the Logging exporter remains unchanged. To use this behavior, switch from the deprecated Logging exporter to Debug exporter.
Link to tracking issue
Testing
Added unit tests for the formatter.
Documentation
Described the formatting in the Debug exporter's README.