Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otelcol] Removed deprecated ConfigProvider field from settings #10281

Merged

Conversation

TylerHelmuth
Copy link
Member

Description

Removes the deprecated ConfigProvider field from CollectorSettings.

@TylerHelmuth TylerHelmuth requested review from a team and codeboten May 31, 2024 17:30
@TylerHelmuth
Copy link
Member Author

@TylerHelmuth TylerHelmuth requested a review from mx-psi May 31, 2024 18:29
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@d55d042). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10281   +/-   ##
=======================================
  Coverage        ?   92.48%           
=======================================
  Files           ?      387           
  Lines           ?    18255           
  Branches        ?        0           
=======================================
  Hits            ?    16884           
  Misses          ?     1025           
  Partials        ?      346           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten merged commit b6510d0 into open-telemetry:main May 31, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone May 31, 2024
@TylerHelmuth TylerHelmuth deleted the otelcol-remove-deprecations branch May 31, 2024 20:35
steves-canva pushed a commit to Canva/opentelemetry-collector that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants