Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[confighttp] Allow compression list for a server to be overridden #10295

Merged
merged 5 commits into from
Jun 13, 2024
Merged

[confighttp] Allow compression list for a server to be overridden #10295

merged 5 commits into from
Jun 13, 2024

Conversation

jpkrohling
Copy link
Member

  • [confighttp] Allow compression list for a server to be overridden
  • changelog

jpkrohling added 2 commits June 3, 2024 17:50
@jpkrohling
[confighttp] Allow compression list for a server to be overridden
8c9f5bb 
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling
changelog
33417b2 
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling jpkrohling requested review from a team and TylerHelmuth June 3, 2024 15:52
@codecov Codecov
Copy link

codecov bot commented Jun 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.65%. Comparing base (7dbaebb) to head (601d3f8).
Report is 1 commits behind head on main.

Files Patch % Lines
config/confighttp/compression.go 89.18% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10295   +/-   ##
=======================================
  Coverage   92.65%   92.65%           
=======================================
  Files         386      386           
  Lines       18232    18238    +6     
=======================================
+ Hits        16892    16898    +6     
  Misses        996      996           
  Partials      344      344

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

codeboten
codeboten reviewed Jun 3, 2024
View reviewed changes
.chloggen/jpkroehling_allow-compression-list-to-be-overridden.yaml Outdated Show resolved Hide resolved
config/confighttp/confighttp.go Outdated Show resolved Hide resolved
config/confighttp/confighttp.go Outdated Show resolved Hide resolved
@jpkrohling
review suggestions, fixed changelog
940456f 
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling jpkrohling requested a review from codeboten June 3, 2024 20:03
@jpkrohling
lint
4a31020 
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
codeboten
codeboten approved these changes Jun 3, 2024
View reviewed changes
config/confighttp/confighttp.go Outdated Show resolved Hide resolved
@jpkrohling
s/defaultCompressionList/defaultCompressionAlgorithms
601d3f8 
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling
Copy link
Member Author

@codeboten , is this OK to be merged?

@codeboten codeboten merged commit 725e869 into open-telemetry:main Jun 13, 2024
48 of 49 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.104.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpkrohling @codeboten