[cmd/builder] Allow setting DefaultScheme in builder config #10296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10296 +/- ##
=======================================
Coverage 92.62% 92.63%
=======================================
Files 386 386
Lines 18236 18237 +1
=======================================
+ Hits 16892 16893 +1
Misses 1000 1000
Partials 344 344 ☔ View full report in Codecov by Sentry. |
codeboten
reviewed
Jun 3, 2024
jpkrohling
reviewed
Jun 3, 2024
There was a problem hiding this comment.
Other than the naming issue that @codeboten mentioned, this might need some documentation as well.
codeboten
reviewed
Jun 3, 2024
evan-bradley
reviewed
Jun 3, 2024
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
evan-bradley
approved these changes
Jun 4, 2024
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
codeboten
reviewed
Jun 4, 2024
TylerHelmuth
commented
Jun 4, 2024
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows configuring
DefaultSchemevia the builder config.Link to tracking issue
Related to #10259
Related to #10290
Testing
Local testing and unit tests