-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[service] fix: use ipv6-aware host and port concatenation function #10343
[service] fix: use ipv6-aware host and port concatenation function #10343
Conversation
86200a0
to
53bfa68
Compare
53bfa68
to
c86f3cc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10343 +/- ##
==========================================
- Coverage 92.40% 92.34% -0.06%
==========================================
Files 393 393
Lines 18588 18620 +32
==========================================
+ Hits 17176 17195 +19
- Misses 1057 1068 +11
- Partials 355 357 +2 ☔ View full report in Codecov by Sentry. |
Is there anything else I have to do to get a review? Note: I did not add a change log because I assumed that changes were made only to internal packages. If this is an incorrect understanding, please point it out. |
Tracking this, as without this fix, it's causing problems with being able to use an up-to-date OTel collector in some IPv6 applications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@terakoya76 sorry that I missed this PR. Everything looks good to me. Please add a bug_fix
changelog entry.
@TylerHelmuth |
Description
Fixing the bug: the latest version of otel-collector failed to start with ipv6 metrics endpoint service telemetry.
This problem began to occur after #9037 with the feature gate flag enabled was merged. This problem is probably an implementation omission because the enabled codepath, which was originally added by #7871, is marked as WIP.
You can reproduce the issue with the config and the environment variable (
MY_POD_IP=::1
).Link to tracking issue
Fixes #10011
Testing
Added unittests to ensure the collector service to work with ipv6 metrics endpoint service telemetry.
I wondered whether to add a
network
argument, which is used as switching flag, to theGetAvailableLocalAddress
function or create a new dedicated function for IPv6.Since the
GetAvailableLocalAddress
function is widely used and its usage is usually assumed to be for IPv4, I chose the latter, not wanting to add more arguments each time we call.Documentation