-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processorhelper] update units for metrics #10647
[processorhelper] update units for metrics #10647
Conversation
This updates units for processhelper's internal telemetry. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10647 +/- ##
==========================================
+ Coverage 92.32% 92.33% +0.01%
==========================================
Files 397 403 +6
Lines 18701 18733 +32
==========================================
+ Hits 17265 17297 +32
Misses 1076 1076
Partials 360 360 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of ignorance, what kind of change do we consider changing metric units? Do we need a changelog entry for this?
I believe we should have a changelog for this, will add one shortly |
Changelog added, PTAL @crobert-1 |
This updates units for processhelper's internal telemetry.
Related #10556
Fixes #10651
For this PR i updated
metadata.yaml
and ranmake gogenerate
, thenmake -C processor test