Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service] Remove getBallastSize from service #10696

Merged

Fix lint

5cf26c5
Select commit
Loading
Failed to load commit list.
Merged

[service] Remove getBallastSize from service #10696

Fix lint
5cf26c5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 22, 2024 in 0s

92.25% (target 90.00%)

View this Pull Request on Codecov

92.25% (target 90.00%)

Details

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.25%. Comparing base (9ef6356) to head (5cf26c5).

Files Patch % Lines
internal/memorylimiter/memorylimiter.go 0.00% 1 Missing ⚠️
service/service.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10696      +/-   ##
==========================================
- Coverage   92.39%   92.25%   -0.15%     
==========================================
  Files         403      403              
  Lines       18744    18723      -21     
==========================================
- Hits        17318    17272      -46     
- Misses       1066     1096      +30     
+ Partials      360      355       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.