Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make @pjanotti owner of windows/amd64 #10788

Merged

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Aug 1, 2024

I'm volunteering myself to own the tier 2 support for windows/amd64. This will put the windows/amd64 on par with the other tier 2 platforms by having a specific person owning it.

Some of Windows related things that I contribute(d):

@pjanotti pjanotti requested review from a team and mx-psi August 1, 2024 18:23
@atoulme atoulme added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.71%. Comparing base (2bb2613) to head (fc8f7ae).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10788   +/-   ##
=======================================
  Coverage   91.71%   91.71%           
=======================================
  Files         406      406           
  Lines       18947    18947           
=======================================
  Hits        17377    17377           
  Misses       1211     1211           
  Partials      359      359           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pjanotti!

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pjanotti

@codeboten codeboten merged commit 88adaef into open-telemetry:main Aug 1, 2024
62 of 67 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 1, 2024
@pjanotti pjanotti deleted the pjanotti-as-owner-for-windows-amd64 branch August 1, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants