Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] improve release version validations #10826

Conversation

mowies
Copy link
Member

@mowies mowies commented Aug 7, 2024

Description

This PR improves the version validation during the release preparation workflow.

Link to tracking issue

Fixes #10735

mowies added 3 commits August 7, 2024 10:58
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.64%. Comparing base (72c7d7f) to head (559644b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10826   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         406      406           
  Lines       18987    18987           
=======================================
  Hits        17400    17400           
  Misses       1227     1227           
  Partials      360      360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mowies mowies marked this pull request as ready for review August 7, 2024 09:43
@mowies mowies requested review from a team and codeboten August 7, 2024 09:43
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mowies ! LGTM

@codeboten codeboten merged commit 4889aef into open-telemetry:main Aug 9, 2024
50 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 9, 2024
@mowies mowies deleted the better-version-validations branch August 16, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] validate-versions workflow should validate versions only when a release is needed
3 participants