Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Refactor service/host into service/internal/graph #10854

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

TylerHelmuth
Copy link
Member

Description

This is a prep PR to reduce the size of #10777. As part of the work to make our component.Host implementation implement componentstatus.Reporter (see #10852), the host struct and graph logic need to be closer together. This is because, as part of #10777 StartAll is changed to depend on our specific Host type instead of a component.Host. Our host already has a dependency on graph, so it can't be moved into its own module.

Link to tracking issue

Related to #10777
Related to #10413

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 72.91667% with 26 lines in your changes missing coverage. Please review.

Project coverage is 91.64%. Comparing base (643c17e) to head (c12fd05).

Files Patch % Lines
service/internal/graph/host.go 75.32% 19 Missing ⚠️
service/service.go 63.15% 0 Missing and 7 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10854   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         406      405    -1     
  Lines       19001    19001           
=======================================
  Hits        17414    17414           
  Misses       1227     1227           
  Partials      360      360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi merged commit d5d1f82 into open-telemetry:main Aug 14, 2024
48 of 49 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 14, 2024
@TylerHelmuth TylerHelmuth deleted the service-refactor-host branch August 14, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants