Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: remove testifylint from Makefile #11236

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Sep 20, 2024

Description

All Testifylint rules are now fixed and ensured to be applied with golangci-lint.
This removes the helper configuration in Makefile and tools module.

@mmorel-35 mmorel-35 requested a review from a team as a code owner September 20, 2024 19:31
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks @mmorel-35!

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.80%. Comparing base (7253ab8) to head (d8833ee).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11236   +/-   ##
=======================================
  Coverage   91.80%   91.80%           
=======================================
  Files         424      424           
  Lines       20094    20094           
=======================================
  Hits        18447    18447           
  Misses       1268     1268           
  Partials      379      379           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu merged commit d17559b into open-telemetry:main Sep 20, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 20, 2024
@mmorel-35 mmorel-35 deleted the makefile/testifylint branch September 20, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants