Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service] Start refactor of GetExporters #11249

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

TylerHelmuth
Copy link
Member

@TylerHelmuth TylerHelmuth commented Sep 23, 2024

Description

As part of #11204 I left host's implementation of GetExporters alone, thinking I didn't need to change a deprecated interface implementation.

But GetExporters depends on component.DataType, so we won't be able to remove component.DataType unless GetExporters is updated to use pipeline.Signal instead.

This PR deprecates the deprecated GetExporters interface with GetExportersWithSignal, which uses pipeline.Signal. Then we'll follow the process to rename GetExportersWithSignal back to GetExporters.

@TylerHelmuth TylerHelmuth added the release:blocker The issue must be resolved before cutting the next release label Sep 23, 2024
@TylerHelmuth
Copy link
Member Author

@djaglowski @dmitryax @tigrannajaryan this is pretty annoying to do for an interface we already want to remove. It would be nice to keep progress moving on #7370

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.42%. Comparing base (66f41f9) to head (cc4faf4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11249   +/-   ##
=======================================
  Coverage   91.41%   91.42%           
=======================================
  Files         424      424           
  Lines       20198    20187   -11     
=======================================
- Hits        18465    18455   -10     
+ Misses       1349     1348    -1     
  Partials      384      384           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten merged commit 20f73e2 into open-telemetry:main Sep 23, 2024
47 of 51 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 23, 2024
@TylerHelmuth TylerHelmuth deleted the rename-getexporters branch September 23, 2024 17:47
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Sep 24, 2024
#### Description
As part of
open-telemetry#11204 I
left `host`'s implementation of `GetExporters` alone, thinking I didn't
need to change a deprecated interface implementation.

But `GetExporters` depends on `component.DataType`, so we won't be able
to remove `component.DataType` unless `GetExporters` is updated to use
`pipeline.Signal` instead.

This PR deprecates the deprecated `GetExporters` interface with
`GetExportersWithSignal`, which uses `pipeline.Signal`. Then we'll
follow the process to rename `GetExportersWithSignal` back to
`GetExporters`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:blocker The issue must be resolved before cutting the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants