Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated scraperhelper.NewScraperWithComponentType #11294

Merged

Conversation

mrasu
Copy link
Contributor

@mrasu mrasu commented Sep 28, 2024

Description

Remove deprecated scraperhelper.NewScraperWithComponentType

This is the last change for #9473

Link to tracking issue

Fixes #9473

@mrasu mrasu requested a review from a team as a code owner September 28, 2024 07:02
@mrasu mrasu requested a review from songy23 September 28, 2024 07:02
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.48%. Comparing base (d128618) to head (38237aa).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11294   +/-   ##
=======================================
  Coverage   91.47%   91.48%           
=======================================
  Files         424      424           
  Lines       20219    20217    -2     
=======================================
  Hits        18495    18495           
+ Misses       1341     1339    -2     
  Partials      383      383           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu merged commit 52e11ec into open-telemetry:main Sep 28, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 28, 2024
@mrasu mrasu deleted the remove-scraper-with-component-type branch September 28, 2024 17:10
jackgopack4 pushed a commit to jackgopack4/opentelemetry-collector that referenced this pull request Oct 8, 2024
…elemetry#11294)

#### Description
Remove deprecated `scraperhelper.NewScraperWithComponentType`

This is the last change for open-telemetry#9473

<!-- Issue number if applicable -->
#### Link to tracking issue
Fixes open-telemetry#9473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scraperhelper.NewScraper is awkward to use
2 participants