[exporter] moving queue sender from pushing model to pulling model #11414
+286
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11414 +/- ##
==========================================
- Coverage 92.15% 92.11% -0.05%
==========================================
Files 431 432 +1
Lines 20238 20382 +144
==========================================
+ Hits 18650 18774 +124
- Misses 1227 1240 +13
- Partials 361 368 +7 ☔ View full report in Codecov by Sentry. |
sfc-gh-sili
force-pushed
the
sili-queue-batcher-new
branch
10 times, most recently
from
220383e
to
66f55f2
Compare
sfc-gh-sili
changed the title
bogdandrutu
previously approved these changes
Oct 13, 2024
| be.BatchMergeSplitfunc = bs.mergeSplitFunc | ||
|
|
||
| if !be.queueCfg.Enabled { | ||
| be.BatchSender = bs |
There was a problem hiding this comment.
Do you need to create bs at all if not used for !be.queueCfg.Enabled?
There was a problem hiding this comment.
This is related to #11414 (comment). The only reason batch sender is initialized here when !be.queueCfg.Enabled is to set up batchMergeFunc.
This can be removed once #11448 is merged.
bogdandrutu
reviewed
Oct 13, 2024
bogdandrutu
dismissed
their stale review
Approved by mistake, PR looks good but needs some more review.
sfc-gh-sili
force-pushed
the
sili-queue-batcher-new
branch
from
66f55f2
to
e37b01e
Compare
sfc-gh-sili
force-pushed
the
sili-queue-batcher-new
branch
2 times, most recently
from
412e1a0
to
963ef11
Compare
dmitryax
pushed a commit
that referenced
this pull request
Oct 16, 2024
… that operates on batch sender (#11448) #### Description As part of the effort to solve #10368, we no longer guarantee to initialize a `batchSender` when `batcher` is enabled. Therefore, we would like to remove the interface to set `mergeFunc` and `mergeSplitFunc` as a callback that operates on `batchSender`. Instead, users should use the alternative `WithBatchFuncs` that is a callback that operates `baseExporter`. Context: #11414 #### Link to tracking issue #8122 #10368 --------- Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
sfc-gh-sili
force-pushed
the
sili-queue-batcher-new
branch
from
34dd771
to
03b28df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a new component that pulls from queueSender to solve the issue mentioned in #10368.
The idea is that instead of allocating a group of reading goroutine and block them until the corresponding batch gets flushed, we now use a goroutine to read and then use the same goroutine go flush while allocating new goroutine to read.
Design doc:
https://docs.google.com/document/d/1y5jt7bQ6HWt04MntF8CjUwMBBeNiJs2gV4uUZfJjAsE/edit?usp=sharing
Link to tracking issue
#8122
Fixes #10368
Testing
Documentation