[docs/rfc] Define RFC merge process #11416
Open
+69
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11416 +/- ##
========================================
Coverage 92.14% 92.14%
========================================
Files 432 433 +1
Lines 20255 20389 +134
========================================
+ Hits 18663 18787 +124
- Misses 1230 1238 +8
- Partials 362 364 +2 ☔ View full report in Codecov by Sentry. |
mx-psi
added
Skip Changelog
|
cc @open-telemetry/collector-approvers |
djaglowski
approved these changes
Oct 16, 2024
songy23
reviewed
Oct 16, 2024
dmitryax
approved these changes
Oct 16, 2024
bogdandrutu
approved these changes
Oct 16, 2024
codeboten
approved these changes
Oct 16, 2024
- Add labels `rfc:final-comment-period` and `rfc:vote-needed` and indicate its usage. - Modify last section to apply same rules for modifying existing RFCs - Make re-requesting reviews mandatory
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
songy23
approved these changes
Oct 17, 2024
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
evan-bradley
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Define RFC merge process in the
docs/rfc/README.md. This is meant to be a tool for making decisions about hard stuff :)