[chore] [pdatagen] Allow slices in the pcommon package #11474
+192
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
pdatagen-allow-common-slices
branch
from
a116190
to
e973da4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11474 +/- ##
=======================================
Coverage 92.14% 92.14%
=======================================
Files 433 433
Lines 20389 20389
=======================================
Hits 18787 18787
Misses 1238 1238
Partials 364 364 ☔ View full report in Codecov by Sentry. |
bogdandrutu
reviewed
Oct 17, 2024
Comment on lines
+79
to
+81
| func generateTestInstrumentationScope() InstrumentationScope { | ||
| return InstrumentationScope(internal.GenerateTestInstrumentationScope()) | ||
| } |
There was a problem hiding this comment.
This is not expected correct?
There was a problem hiding this comment.
This is expected to be able to remove https://github.com/open-telemetry/opentelemetry-collector/pull/11474/files#diff-a2f357985c40abe2729795f5dd99e3dae74e199973c49540be215dbd4026ea69L61-L66 and don't bring the same to the slices. Seems cleaner to me, but let me know if you think otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, pdatagen doesn't allow defining slices in the common package, while all other types do allow it. This is needed for #11282