Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config settings for component telemetry, move the flag #2148

Merged
merged 1 commit into from
Nov 14, 2020

Conversation

bogdandrutu
Copy link
Member

Next steps will be to use the new settings in the processors.

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Next steps will be to use the new settings in the processors.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested a review from a team November 13, 2020 21:31
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #2148 (e64a0e8) into master (3e3b201) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2148      +/-   ##
==========================================
+ Coverage   92.19%   92.20%   +0.01%     
==========================================
  Files         280      280              
  Lines       16981    16996      +15     
==========================================
+ Hits        15655    15672      +17     
+ Misses        908      907       -1     
+ Partials      418      417       -1     
Impacted Files Coverage Δ
internal/collector/telemetry/telemetry.go 94.44% <ø> (-1.56%) ⬇️
config/configtelemetry/configtelemetry.go 100.00% <100.00%> (ø)
processor/batchprocessor/factory.go 100.00% <100.00%> (ø)
processor/metrics.go 78.57% <100.00%> (ø)
service/service.go 52.89% <100.00%> (+0.18%) ⬆️
service/telemetry.go 83.92% <100.00%> (+2.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3b201...e64a0e8. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 6ac579e into open-telemetry:master Nov 14, 2020
@bogdandrutu bogdandrutu deleted the configtel branch November 14, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants