Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --log-format command line option (default to "console") #2177

Conversation

tigrannajaryan
Copy link
Member

Contributes to #2102

@tigrannajaryan tigrannajaryan requested a review from a team November 18, 2020 01:54
@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #2177 (ace05b8) into master (6b67312) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2177   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files         280      280           
  Lines       16975    16977    +2     
=======================================
+ Hits        15658    15660    +2     
  Misses        903      903           
  Partials      414      414           
Impacted Files Coverage Δ
service/logger.go 71.42% <100.00%> (+3.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b67312...ace05b8. Read the comment docs.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: not from this PR, but the logic to select the base conf looks very complicated :)

@tigrannajaryan tigrannajaryan merged commit 02781c0 into open-telemetry:master Nov 18, 2020
@tigrannajaryan tigrannajaryan deleted the feature/tigran/log-format-option branch November 18, 2020 16:10
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants