Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1/2] Add Security workflows: CodeQL scan workflow #2325

Merged
merged 3 commits into from
Jan 4, 2021

Conversation

amanbrar1999
Copy link
Contributor

@amanbrar1999 amanbrar1999 commented Dec 30, 2020

Motivation

Follow up to issue open-telemetry/oteps#144

CodeQL is GitHub's static analysis engine which scans repos for security vulnerabilities. As the project grows and we near GA it might be useful to have a workflow which checks for security vulnerabilities with every PR so we can ensure every incremental change is following best development practices. Also passing basic security checks will also make sure that there aren't any glaring issues for our users.

Changes

  • This PR adds CodeQL security checks to the repo
  • After every run the workflow uploads the results to GitHub. Details on the run and security alerts will show up in the security tab of this repo.

Workflow Triggers

  • daily cron job at 1:30am
  • workflow_dispatch (in case maintainers want to trigger a security check manually)

cc- @alolita

@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #2325 (5103fa4) into master (86ec919) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2325   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files         273      273           
  Lines       15367    15367           
=======================================
  Hits        14141    14141           
  Misses        845      845           
  Partials      381      381           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86ec919...5103fa4. Read the comment docs.

@bogdandrutu bogdandrutu merged commit a3facee into open-telemetry:master Jan 4, 2021
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants