Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable golint comments check #2873

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested a review from a team March 31, 2021 23:56
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #2873 (2f58e4b) into main (1edaf40) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2873   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files         286      286           
  Lines       15087    15087           
=======================================
  Hits        13846    13846           
- Misses        848      849    +1     
+ Partials      393      392    -1     
Impacted Files Coverage Δ
testutil/testutil.go 81.60% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1edaf40...2f58e4b. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 6fc26c3 into open-telemetry:main Apr 1, 2021
@bogdandrutu bogdandrutu deleted the enableexc2 branch April 1, 2021 01:41
@mx-psi mx-psi mentioned this pull request Apr 6, 2021
3 tasks
pjanotti pushed a commit to pjanotti/opentelemetry-service that referenced this pull request Apr 6, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
* Mark our internal pulsar exporter as deprecated, indicate we will move to the upstream exporter

* fix deprecation warnings

* add warning log when using the exporter
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants