Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mdatagen to create factories of init instead of new #2978

Merged
merged 2 commits into from
Apr 21, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested a review from a team April 21, 2021 17:00
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #2978 (6aaef42) into main (13e4566) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2978      +/-   ##
==========================================
- Coverage   91.63%   91.63%   -0.01%     
==========================================
  Files         312      312              
  Lines       15404    15402       -2     
==========================================
- Hits        14116    14114       -2     
  Misses        881      881              
  Partials      407      407              
Impacted Files Coverage Δ
consumer/simple/metrics.go 98.63% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13e4566...6aaef42. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 0694cac into open-telemetry:main Apr 21, 2021
@bogdandrutu bogdandrutu deleted the initmetrics branch April 21, 2021 18:07
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…-agent (open-telemetry#2978)

* Bump github.com/go-errors/errors in /pkg/signalfx-agent

Bumps [github.com/go-errors/errors](https://github.com/go-errors/errors) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/go-errors/errors/releases)
- [Commits](go-errors/errors@v1.4.1...v1.4.2)

---
updated-dependencies:
- dependency-name: github.com/go-errors/errors
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* make tidy

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants