-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exporters/prometheusremotewrite: Do not append '_total' to counter metric names #2993
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2993 +/- ##
==========================================
- Coverage 92.06% 91.65% -0.42%
==========================================
Files 313 312 -1
Lines 15439 15427 -12
==========================================
- Hits 14214 14139 -75
- Misses 817 881 +64
+ Partials 408 407 -1
Continue to review full report at Codecov.
|
…tric names. This appears to have been enforcing convention but isn't actually required. Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
233114c
to
420f897
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @odeke-em
…tor into prom_name_label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @Aneurysm9!
Kindly cc-ing @bogdandrutu. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
cc @open-telemetry/collector-approvers |
@anuraaga @open-telemetry/collector-approvers - please take a look and approve. There are other Prometheus issues that are dependent on this fix being merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nits
…tor into prom_name_label
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! LGTM
…tor into prom_name_label
…tor into prom_name_label
…n PRW exporter Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
I think this needs a rebase to pass the required checks |
…tor into prom_name_label
…tric names (open-telemetry#2993) * exporters/prometheusremotewrite: Do not append '_total' to counter metric names. This appears to have been enforcing convention but isn't actually required. Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> * Address PR feedback Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> * Update CHANGELOG.md to reflect removal of _total suffix enforcement in PRW exporter Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Co-authored-by: jeffreyc-splunk <jeffreyc-splunk@users.noreply.github.com>
This appears to have been enforcing convention but isn't actually required.
Description: The
prometheusremotewriteexporter
no longer appends "_total" to the name of counter metrics that don't already end in "_total". This was exposed by the PRW conformance test suite and this change partially addresses open-telemetry/wg-prometheus#43.