Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create go.opentelemetry.io/collector/model as a separate module #3530

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

bogdandrutu
Copy link
Member

Fixes #3104

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested review from a team and jrcamp June 30, 2021 00:56
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu changed the title Create an go.opentelemetry.io/collector/model as a separate module Create go.opentelemetry.io/collector/model as a separate module Jun 30, 2021
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Is fixing the contrib trivial?

@bogdandrutu
Copy link
Member Author

Only go mod changes are required for contrib which I cannot make until we merge this

@bogdandrutu bogdandrutu merged commit b2ca27e into open-telemetry:main Jun 30, 2021
@bogdandrutu bogdandrutu deleted the extractpdata branch June 30, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract pdata into a separate Go Module
3 participants