Add a memory limiter processor #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
requested review from
bogdandrutu,
flands,
owais,
pjanotti,
rghetia and
songy23
as code owners
For it to be effective it needs to be right after the receivers, ie.: first processor on the pipeline. |
Right, I keep forgetting that batch is also async. |
Codecov Report
@@ Coverage Diff @@
## master #498 +/- ##
==========================================
+ Coverage 75.73% 75.96% +0.22%
==========================================
Files 119 122 +3
Lines 7414 7551 +137
==========================================
+ Hits 5615 5736 +121
- Misses 1530 1543 +13
- Partials 269 272 +3
Continue to review full report at Codecov.
|
pjanotti
approved these changes
Jan 13, 2020
joe-elliott
reviewed
Jan 14, 2020
owais
approved these changes
Jan 14, 2020
This adds a processor that drops data according to configured memory limits. The processor is important for high load situations when receiving rate exceeds exporting rate (and an extreme case of this is when the target of exporting is unavailable). Typical production run will need to have this processor included in every pipeline immediately after the batch processor.
tigrannajaryan
force-pushed
the
feature/tigran/memory-limit
branch
from
34123a2
to
c2ed0c7
Compare
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a processor that drops data according to configured memory limits.
The processor is important for high load situations when receiving rate exceeds exporting
rate (and an extreme case of this is when the target of exporting is unavailable).
Typical production run will need to have this processor included in every pipeline
as the first processor (it needs to be the first to be effective).