[pdata] Change outcome of Metric data accessors misuse #5035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5035 +/- ##
==========================================
+ Coverage 91.08% 91.10% +0.01%
==========================================
Files 180 180
Lines 10700 10720 +20
==========================================
+ Hits 9746 9766 +20
Misses 737 737
Partials 217 217
Continue to review full report at Codecov.
|
dmitryax
force-pushed
the
change-metric-type-accessor-behavior
branch
from
9ca8a6e
to
f6c0795
Compare
Aneurysm9
approved these changes
Mar 18, 2022
dmitryax
force-pushed
the
change-metric-type-accessor-behavior
branch
from
f6c0795
to
6c0e47a
Compare
bogdandrutu
approved these changes
Mar 21, 2022
mx-psi
reviewed
Mar 21, 2022
Change outcome of `pdata.Metric.<Gauge|Sum|Histogram|ExponentialHistogram>()` functions misuse. In case of type mismatch, they don't panic right away but return an invalid zero-initialized instance for consistency with other OneOf field accessors
dmitryax
force-pushed
the
change-metric-type-accessor-behavior
branch
from
6c0e47a
to
584a8c4
Compare
mx-psi
approved these changes
Mar 21, 2022
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this pull request
Jun 7, 2022
…y#5035) Change outcome of `pdata.Metric.<Gauge|Sum|Histogram|ExponentialHistogram>()` functions misuse. In case of type mismatch, they don't panic right away but return an invalid zero-initialized instance for consistency with other OneOf field accessors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change outcome of
pdata.Metric.<Gauge|Sum|Histogram|ExponentialHistogram>()functions misuse. In case of type mismatch, they don't panic right away but return an invalid zero-initialized instance for consistency with other OneOf field accessorsLink to tracking Issue: #4775