Do not set TraceProvider to global #5138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5138 +/- ##
==========================================
+ Coverage 89.90% 89.94% +0.03%
==========================================
Files 182 182
Lines 11080 11077 -3
==========================================
+ Hits 9962 9963 +1
+ Misses 892 889 -3
+ Partials 226 225 -1
Continue to review full report at Codecov.
|
Aneurysm9
approved these changes
Apr 1, 2022
codeboten
approved these changes
Apr 2, 2022
codeboten
added
Skip Changelog
codeboten
reviewed
Apr 2, 2022
The reason is because soon we will have the config for the tracing/metrics providers in the main config (already started). When this happens then we can have users "reconfigure" that via the watch API, and re-setting the global is not allowed in otel (also not restart friendly). Because of that we should break this behavior now, and not install the global. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
|
@codeboten thanks for reminding me... I forgot to push the changes :)) |
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
Apr 4, 2022
…cs featuregate enabled This PR also removes the set of the global MeterProvider, similarly with open-telemetry#5138. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
Apr 4, 2022
…cs featuregate enabled This PR also removes the set of the global MeterProvider, similarly with open-telemetry#5138. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
Apr 4, 2022
…cs featuregate enabled This PR also removes the set of the global MeterProvider, similarly with open-telemetry#5138. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
Apr 4, 2022
…cs featuregate enabled This PR also removes the set of the global MeterProvider, similarly with open-telemetry#5138. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
Apr 4, 2022
…cs featuregate enabled This PR also removes the set of the global MeterProvider, similarly with open-telemetry#5138. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this pull request
Jun 7, 2022
The reason is because soon we will have the config for the tracing/metrics providers in the main config (already started). When this happens then we can have users "reconfigure" that via the watch API, and re-setting the global is not allowed in otel (also not restart friendly). Because of that we should break this behavior now, and not install the global. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this pull request
Jun 7, 2022
…cs featuregate enabled (open-telemetry#5146) This PR also removes the set of the global MeterProvider, similarly with open-telemetry#5138. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason is because soon we will have the config for the tracing/metrics providers in the main config (already started).
When this happens then we can have users "reconfigure" that via the watch API, and re-setting the global is not allowed in otel (also not restart friendly). Because of that we should break this behavior now, and not install the global.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com