Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdata] Fix Value.asRaw to correctly return Slice and Map elements #5153

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Apr 5, 2022

return statements were missed in the Value.asRaw function for Slice and Map elements.

@dmitryax dmitryax requested review from a team and bogdandrutu April 5, 2022 22:26
`return` statements were missed in the Value.asRaw function for Slice and Map elements.
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #5153 (6af1ec7) into main (f6b1cd9) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5153      +/-   ##
==========================================
+ Coverage   90.30%   90.38%   +0.07%     
==========================================
  Files         182      182              
  Lines       11031    11031              
==========================================
+ Hits         9962     9970       +8     
+ Misses        843      836       -7     
+ Partials      226      225       -1     
Impacted Files Coverage Δ
model/internal/pdata/common.go 94.98% <100.00%> (+1.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6b1cd9...6af1ec7. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 1526d28 into open-telemetry:main Apr 6, 2022
@dmitryax dmitryax deleted the fix-as-raw branch April 6, 2022 00:50
Nicholaswang pushed a commit to Nicholaswang/opentelemetry-collector that referenced this pull request Jun 7, 2022
…pen-telemetry#5153)

`return` statements were missed in the Value.asRaw function for Slice and Map elements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants