Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdata] Extract model/internal/pdata package into model/internal #5162

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Apr 6, 2022

To avoid confusion with model/pdata package and pdata module which we will likely have instead of model based on the latest discussion in #5087

To avoid confusion with `model/pdata` package and future `pdata` module
@dmitryax dmitryax requested review from a team and bogdandrutu April 6, 2022 20:35
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 6, 2022
@dmitryax dmitryax changed the title [pdata] Unpack model/internal/pdata package into model/internal [pdata] Extract model/internal/pdata package into model/internal Apr 6, 2022
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #5162 (1fd26e4) into main (a1c539a) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5162      +/-   ##
==========================================
+ Coverage   90.33%   90.37%   +0.03%     
==========================================
  Files         182      182              
  Lines       11000    11000              
==========================================
+ Hits         9937     9941       +4     
+ Misses        837      834       -3     
+ Partials      226      225       -1     
Impacted Files Coverage Δ
model/internal/common.go 95.06% <ø> (ø)
model/internal/generated_common.go 100.00% <ø> (ø)
model/internal/generated_log.go 96.65% <ø> (ø)
model/internal/generated_metrics.go 97.21% <ø> (ø)
model/internal/generated_resource.go 100.00% <ø> (ø)
model/internal/generated_trace.go 96.89% <ø> (ø)
model/internal/logs.go 81.48% <ø> (ø)
model/internal/metrics.go 87.37% <ø> (ø)
model/internal/otlp_wrapper.go 100.00% <ø> (ø)
model/internal/spanid.go 100.00% <ø> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1c539a...1fd26e4. Read the comment docs.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an internal only change +1

@bogdandrutu
Copy link
Member

I think we may have an issue, because I remember I asked you to do this to remove the confusion between the current public vs internal package.

@bogdandrutu bogdandrutu merged commit c51773a into open-telemetry:main Apr 6, 2022
@dmitryax
Copy link
Member Author

dmitryax commented Apr 6, 2022

I think we may have an issue, because I remember I asked you to do this to remove the confusion between the current public vs internal package.

What issue do you mean? Yes I remember that you asked this, but I thought I would not be needed anymore if we have model/p<signal>

@dmitryax dmitryax deleted the remove-intenal-pdata branch April 6, 2022 20:50
Nicholaswang pushed a commit to Nicholaswang/opentelemetry-collector that referenced this pull request Jun 7, 2022
…-telemetry#5162)

To avoid confusion with `model/pdata` package and future `pdata` module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants