Deprecate configmapprovider package, replace with mapconverter #5167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
depmapconverter
branch
from
4e88b11
to
d49e6f8
Compare
Codecov Report
@@ Coverage Diff @@
## main #5167 +/- ##
==========================================
+ Coverage 90.33% 90.37% +0.03%
==========================================
Files 185 185
Lines 11000 11000
==========================================
+ Hits 9937 9941 +4
+ Misses 837 834 -3
+ Partials 226 225 -1
Continue to review full report at Codecov.
|
bogdandrutu
force-pushed
the
depmapconverter
branch
2 times, most recently
from
3e1d6b9
to
7af1692
Compare
codeboten
reviewed
Apr 8, 2022
The new `config/mapconverter` has the same structure as the `config/mapprovider` so it is consistent. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
depmapconverter
branch
from
7af1692
to
408dc80
Compare
dmitryax
approved these changes
Apr 8, 2022
codeboten
approved these changes
Apr 8, 2022
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this pull request
Jun 7, 2022
…telemetry#5167) The new `config/mapconverter` has the same structure as the `config/mapprovider` so it is consistent. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
config/mapconverterhas the same structure as theconfig/mapproviderso it is consistent.Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com