Deprecate confmap.Conf.Set, not used anywhere for the moment

[bogdandrutu]

Fixes #4467

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

[bogdandrutu]

cc @mx-psi can you tell me about your usage in DD?

I will "deprecate" it, but initially I am trying to see if contrib breaks. Update: contrib passed, so change this to deprecated.

[codecov]

Codecov Report

Merging #5485 (6da9627) into main (0347b25) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5485      +/-   ##
==========================================
- Coverage   90.84%   90.79%   -0.06%     
==========================================
  Files         193      193              
  Lines       11430    11431       +1     
==========================================
- Hits        10384    10379       -5     
- Misses        824      830       +6     
  Partials      222      222              

Impacted Files	Coverage Δ
confmap/confmap.go	84.15% <ø> (-5.95%)	⬇️
config/internal/configsource/manager.go	85.95% <100.00%> (ø)
confmap/converter/expandconverter/expand.go	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0347b25...6da9627. Read the comment docs.

[mx-psi]

cc @mx-psi can you tell me about your usage in DD?

I will "deprecate" it, but initially I am trying to see if contrib breaks. Update: contrib passed, so change this to deprecated.

We use it to build up a confmap.Conf manually from Viper (see here). It's feasible to replace it with a Merge or handle it with something else, I just trusted this code more than using Viper 😄

[mx-psi]

DataDog/datadog-agent/pull/12296 removes all usages of Set on our codebase