Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use opencensus metric package for process metrics #5486

Merged
merged 5 commits into from
Jun 8, 2022

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested review from a team and mx-psi June 6, 2022 23:45
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #5486 (7f5cfea) into main (f1ba384) will decrease coverage by 0.07%.
The diff coverage is 73.10%.

@@            Coverage Diff             @@
##             main    #5486      +/-   ##
==========================================
- Coverage   90.84%   90.76%   -0.08%     
==========================================
  Files         192      192              
  Lines       11420    11479      +59     
==========================================
+ Hits        10374    10419      +45     
- Misses        824      831       +7     
- Partials      222      229       +7     
Impacted Files Coverage Δ
service/internal/telemetry/process_telemetry.go 71.55% <72.97%> (-1.67%) ⬇️
service/telemetry.go 77.24% <75.00%> (-0.16%) ⬇️
pdata/internal/common.go 95.38% <0.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1ba384...7f5cfea. Read the comment docs.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great, just a nit regarding a variable name.

service/internal/telemetry/process_telemetry.go Outdated Show resolved Hide resolved
service/internal/telemetry/process_telemetry.go Outdated Show resolved Hide resolved
service/internal/telemetry/process_telemetry.go Outdated Show resolved Hide resolved
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 992782d into open-telemetry:main Jun 8, 2022
@bogdandrutu bogdandrutu deleted the usemetric branch June 8, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants