Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otlp] update proto to v0.18.0 #5530

Merged
merged 4 commits into from
Jun 13, 2022

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Jun 13, 2022

This change updates the proto to v0.18.0

In this change is also an update to the Sum field of ExponentialHistogramDataPoint to make it optional, which is consistent with HistogramDataPoint.

Fixes #5528
Fixes #5527

@codeboten codeboten requested review from a team and dmitryax June 13, 2022 17:38
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #5530 (ea75920) into main (6abe186) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head ea75920 differs from pull request most recent head c053e1c. Consider uploading reports for the commit c053e1c to get more accurate results

@@            Coverage Diff             @@
##             main    #5530      +/-   ##
==========================================
- Coverage   90.84%   90.81%   -0.04%     
==========================================
  Files         191      191              
  Lines       11362    11365       +3     
==========================================
- Hits        10322    10321       -1     
- Misses        814      817       +3     
- Partials      226      227       +1     
Impacted Files Coverage Δ
pdata/internal/generated_pmetric.go 97.35% <100.00%> (+0.01%) ⬆️
pdata/internal/common.go 94.61% <0.00%> (-0.77%) ⬇️
service/command.go 80.00% <0.00%> (-0.77%) ⬇️
service/flags.go 88.46% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97f455e...c053e1c. Read the comment docs.

@bogdandrutu
Copy link
Member

Please rebase

codeboten added 4 commits June 13, 2022 11:09
Update exponential histogram datapoint sum field to optional.
Copy link
Contributor Author

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bogdandrutu bogdandrutu merged commit 071d196 into open-telemetry:main Jun 13, 2022
@codeboten codeboten deleted the codeboten/expo-histo-sum branch June 22, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update OTLP to v0.18.0 Sum field in exponential histogram datapoint should be optional
2 participants