Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for the new pipelines builder #5544

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

bogdandrutu
Copy link
Member

Depends on #5542

@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 15, 2022
@bogdandrutu bogdandrutu requested a review from a team June 15, 2022 15:09
@bogdandrutu bogdandrutu requested a review from mx-psi June 15, 2022 15:09
@bogdandrutu
Copy link
Member Author

/cc @mx-psi this is the 5th PR extracted from #5512

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #5544 (a354a07) into main (c099f6a) will increase coverage by 0.19%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #5544      +/-   ##
==========================================
+ Coverage   90.80%   90.99%   +0.19%     
==========================================
  Files         194      194              
  Lines       11485    11485              
==========================================
+ Hits        10429    10451      +22     
+ Misses        833      818      -15     
+ Partials      223      216       -7     
Impacted Files Coverage Δ
service/internal/builder/pipelines_builder.go 91.27% <75.00%> (+3.48%) ⬆️
service/internal/builder/receivers_builder.go 83.85% <83.33%> (+1.86%) ⬆️
pdata/internal/common.go 91.85% <0.00%> (-0.75%) ⬇️
service/internal/builder/exporters_builder.go 96.11% <0.00%> (+5.82%) ⬆️
service/internal/pipelines/pipelines.go 82.10% <0.00%> (+9.47%) ⬆️
internal/testcomponents/example_processor.go 100.00% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c099f6a...a354a07. Read the comment docs.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Comment on lines +228 to +229
t.Skip("This is a small issue with current implementation which will be fixed in #5512." +
"In real binary this will not be hit, since the validation of the config will catch this issue in advance.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the issue here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that we build the receivers by looking at configs, and if used in one pipeline we create/initialize it. With this logic if there is a receiver in a pipeline without a config we don't create/initialize it, but this is not a "Valid" config and fails config.Validate().

@bogdandrutu bogdandrutu merged commit 35b844e into open-telemetry:main Jun 20, 2022
@bogdandrutu bogdandrutu deleted the addpipelinetests branch June 20, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants