Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Restore deprecated funcs still in use in third-party dependencies" #5797

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Revert "Restore deprecated funcs still in use in third-party dependencies" #5797

merged 1 commit into from
Aug 3, 2022

Conversation

bogdandrutu
Copy link
Member

Reverts #5786

All third-party code has been updated.

@bogdandrutu bogdandrutu marked this pull request as ready for review August 3, 2022 12:02
@bogdandrutu bogdandrutu requested review from a team and dmitryax August 3, 2022 12:02
@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 3, 2022
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #5797 (8efea43) into main (27fdc2e) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5797      +/-   ##
==========================================
+ Coverage   91.52%   91.58%   +0.06%     
==========================================
  Files         192      192              
  Lines       11433    11421      -12     
==========================================
- Hits        10464    10460       -4     
+ Misses        775      766       -9     
- Partials      194      195       +1
Impacted Files Coverage Δ
pdata/internal/metrics.go 89.03% <ø> (+6.39%) ⬆️
pdata/internal/common.go 94.61% <0.00%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27fdc2e...8efea43. Read the comment docs.

jpkrohling
jpkrohling approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contrib tests are passing

@jpkrohling jpkrohling added the release:blocker The issue must be resolved before cutting the next release label Aug 3, 2022
@jpkrohling jpkrohling mentioned this pull request Aug 3, 2022
Closed
8 tasks
@bogdandrutu bogdandrutu merged commit a585d0d into main Aug 3, 2022
@bogdandrutu bogdandrutu deleted the revert-5786-restoredep branch August 3, 2022 12:50
@mx-psi mx-psi mentioned this pull request Sep 14, 2022
Merged
This was referenced Sep 28, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax

Assignees
No one assigned
Labels
release:blocker The issue must be resolved before cutting the next release Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bogdandrutu @jpkrohling