Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdata] Remove deprecated Flags API #5814

Merged

Conversation

TylerHelmuth
Copy link
Member

@TylerHelmuth TylerHelmuth commented Aug 4, 2022

Description:
Removes deprecated Flags API. FlagsStruct should be used instead.

Relates to #5443

Testing:
Ran unit tests

@TylerHelmuth TylerHelmuth requested review from a team and bogdandrutu August 4, 2022 16:33
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #5814 (8736945) into main (5f3b0d8) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5814      +/-   ##
==========================================
+ Coverage   91.77%   91.82%   +0.04%     
==========================================
  Files         196      196              
  Lines       11946    11920      -26     
==========================================
- Hits        10963    10945      -18     
+ Misses        776      768       -8     
  Partials      207      207              
Impacted Files Coverage Δ
pdata/internal/metrics.go 93.02% <ø> (+3.99%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TylerHelmuth
Copy link
Member Author

Opened open-telemetry/opentelemetry-collector-contrib#12966 to address failure in prometheusreceiver

@TylerHelmuth
Copy link
Member Author

Opened GoogleCloudPlatform/opentelemetry-operations-go#466 to start to address the rest of the failing tests.

@TylerHelmuth
Copy link
Member Author

@bogdandrutu contrib tests are passing now

@bogdandrutu bogdandrutu merged commit 8145eb7 into open-telemetry:main Aug 5, 2022
@TylerHelmuth TylerHelmuth deleted the remove-deprecated-flags branch August 5, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants