Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdata] Deprecate FlagsStruct in favor of Flags #5842

Merged
merged 6 commits into from
Aug 5, 2022

Conversation

TylerHelmuth
Copy link
Member

Description:
Deprecates FlagsStruct in favor of Flags

Link to tracking Issue:
Related to #5443

Testing:
Unit tests

@TylerHelmuth TylerHelmuth requested review from a team and Aneurysm9 August 5, 2022 21:42
@TylerHelmuth
Copy link
Member Author

/cc @bogdandrutu

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #5842 (66901a3) into main (8145eb7) will decrease coverage by 0.10%.
The diff coverage is 72.41%.

@@            Coverage Diff             @@
##             main    #5842      +/-   ##
==========================================
- Coverage   91.82%   91.71%   -0.11%     
==========================================
  Files         196      195       -1     
  Lines       11920    11932      +12     
==========================================
- Hits        10945    10944       -1     
- Misses        768      780      +12     
- Partials      207      208       +1     
Impacted Files Coverage Δ
pdata/internal/metrics.go 87.59% <52.94%> (-5.44%) ⬇️
pdata/internal/generated_pmetric.go 97.33% <100.00%> (ø)
exporter/otlphttpexporter/otlp.go 80.59% <0.00%> (-3.25%) ⬇️
exporter/exporterhelper/queued_retry.go 95.97% <0.00%> (-0.38%) ⬇️
exporter/exporterhelper/queued_retry_inmemory.go

Help us with your feedback. Take ten seconds to tell us how you rate us.

pdata/internal/metrics.go Outdated Show resolved Hide resolved
pdata/internal/metrics.go Outdated Show resolved Hide resolved
pdata/internal/metrics.go Outdated Show resolved Hide resolved
pdata/internal/metrics.go Outdated Show resolved Hide resolved
pdata/internal/metrics.go Outdated Show resolved Hide resolved
pdata/internal/metrics.go Outdated Show resolved Hide resolved
pdata/pmetric/alias.go Outdated Show resolved Hide resolved
pdata/pmetric/alias.go Outdated Show resolved Hide resolved
TylerHelmuth and others added 2 commits August 5, 2022 16:12
Co-authored-by: Bogdan Drutu <lazy@splunk.com>
Co-authored-by: Bogdan Drutu <lazy@splunk.com>
@bogdandrutu bogdandrutu merged commit aa6074d into open-telemetry:main Aug 5, 2022
@TylerHelmuth TylerHelmuth deleted the deprecate-flagsstruct branch August 5, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants