Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate config.[Receiver|Processor|Exporter|Extension].ID() and SetName() #5870

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Deprecate config.[Receiver|Processor|Exporter|Extension].ID() and SetName() #5870

merged 1 commit into from
Nov 29, 2022

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Aug 8, 2022 •
edited
Loading

Updates #4714

Signed-off-by: Bogdan bogdandrutu@gmail.com

@bogdandrutu bogdandrutu force-pushed the deprecateid branch 2 times, most recently from c08fd7b to cf6cbe3 Compare August 9, 2022 22:32
@bogdandrutu bogdandrutu marked this pull request as ready for review August 9, 2022 22:32
@bogdandrutu bogdandrutu requested review from a team and codeboten August 9, 2022 22:32
@codecov
Copy link

codecov bot commented Aug 9, 2022 •
edited
Loading

Codecov Report

Base: 91.21% // Head: 91.20% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (2ce6510) compared to base (4ff1ff3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5870      +/-   ##
==========================================
- Coverage   91.21%   91.20%   -0.01%     
==========================================
  Files         245      245              
  Lines       14194    14201       +7     
==========================================
+ Hits        12947    12952       +5     
- Misses        997      999       +2     
  Partials      250      250
Impacted Files Coverage Δ
component/config.go 87.50% <ø> (ø)
component/exporter.go 100.00% <ø> (ø)
component/extension.go 100.00% <ø> (ø)
component/identifiable.go 100.00% <ø> (ø)
component/processor.go 100.00% <ø> (ø)
component/receiver.go 100.00% <ø> (ø)
config/settings.go 66.66% <ø> (-33.34%) ⬇️
exporter/exporterhelper/common.go 90.80% <100.00%> (ø)
exporter/exporterhelper/logs.go 80.64% <100.00%> (ø)
exporter/exporterhelper/metrics.go 80.64% <100.00%> (ø)
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu changed the title Deprecate config.[Receiver|Processor|Exporter|Extension].ID() and Set… Deprecate config.[Receiver|Processor|Exporter|Extension].ID() and SetName() Aug 9, 2022
@bogdandrutu bogdandrutu marked this pull request as draft August 9, 2022 23:17
@bogdandrutu bogdandrutu force-pushed the deprecateid branch 2 times, most recently from 61e849c to e7aaf8d Compare August 16, 2022 00:19
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 7, 2022
@bogdandrutu bogdandrutu removed the Stale label Sep 9, 2022
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 24, 2022
@bogdandrutu bogdandrutu removed the Stale label Sep 25, 2022
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 10, 2022
@bogdandrutu bogdandrutu removed the Stale label Oct 10, 2022
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 25, 2022
@bogdandrutu bogdandrutu removed the Stale label Oct 25, 2022
@bogdandrutu bogdandrutu mentioned this pull request Oct 31, 2022
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 9, 2022
@bogdandrutu bogdandrutu removed the Stale label Nov 23, 2022
@bogdandrutu bogdandrutu marked this pull request as ready for review November 24, 2022 01:28
dmitryax
dmitryax approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bogdandrutu
Deprecate component.Config.ID(), add helper for obsreporttest
2ce6510 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codeboten codeboten merged commit d0fe772 into open-telemetry:main Nov 29, 2022
@bogdandrutu bogdandrutu deleted the deprecateid branch November 29, 2022 23:43
jaronoff97 added a commit to lightstep/opentelemetry-collector that referenced this pull request Dec 14, 2022
@jaronoff97
Deprecate component.Config.ID(), add helper for obsreporttest (open-t…
6f7039e 
…elemetry#5870)

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
jaronoff97 added a commit to lightstep/opentelemetry-collector that referenced this pull request Dec 14, 2022
@jaronoff97
Deprecate component.Config.ID(), add helper for obsreporttest (open-t…
2dfbd33 
…elemetry#5870)

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@dmitryax dmitryax dmitryax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bogdandrutu @codeboten @dmitryax