Enforce naming conventions for Invalid[Trace|Span]ID #5969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the rules here https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#naming-convention Also this changes Invalid -> Empty to match the "IsEmpty" func. Signed-off-by: Bogdan <bogdandrutu@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #5969 +/- ##
==========================================
- Coverage 92.30% 92.27% -0.04%
==========================================
Files 212 212
Lines 13263 13263
==========================================
- Hits 12243 12239 -4
- Misses 803 807 +4
Partials 217 217
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dmitryax
approved these changes
Aug 25, 2022
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the rules here https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#naming-convention
Also this changes Invalid -> Empty to match the "IsEmpty" func.
Signed-off-by: Bogdan bogdandrutu@gmail.com