Deprecate pmetric.Metric.SetDataType, in favor of empty setters #5979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
setemptyoneof
branch
from
7bfb4bd
to
84e034d
Compare
Codecov ReportBase: 92.07% // Head: 91.99% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5979 +/- ##
==========================================
- Coverage 92.07% 91.99% -0.08%
==========================================
Files 213 213
Lines 13323 13340 +17
==========================================
+ Hits 12267 12272 +5
- Misses 838 850 +12
Partials 218 218
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dmitryax
reviewed
Sep 2, 2022
|
@bogdandrutu |
bogdandrutu
force-pushed
the
setemptyoneof
branch
from
9ce8823
to
35abf96
Compare
|
@dmitryax PTAL |
Signed-off-by: Bogdan <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
setemptyoneof
branch
from
35abf96
to
994a401
Compare
dmitryax
approved these changes
Sep 2, 2022
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan bogdandrutu@gmail.com