[chore] Drop builtin builder configuration integration tests. #6157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpeach
changed the title
Drop the integration tests for the builtin builder configuration. We assume that it is a working config because it is generated from with the source tree and should be covered by collector tests. Add a unit test to ensure some basic sanity for the builtin configuration. This fixes open-telemetry#6076. Signed-off-by: James Peach <jpeach@cloudflare.com>
jpeach
force-pushed
the
builtin-default-test
branch
from
4cbe77e
to
d20ccda
Compare
Codecov ReportBase: 91.76% // Head: 91.76% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6157 +/- ##
=======================================
Coverage 91.76% 91.76%
=======================================
Files 217 218 +1
Lines 13350 13352 +2
=======================================
+ Hits 12251 12253 +2
Misses 870 870
Partials 229 229
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jpkrohling
approved these changes
Sep 27, 2022
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Drop the integration tests for the builtin builder configuration. We assume that it is a working config because it is generated from with the source tree and should be covered by collector tests. Add a unit test to ensure some basic sanity for the builtin configuration.
Link to tracking Issue: This fixes #6076.
Testing: Ran unit an integration tests.
Documentation: N/A