[pdata] Update pcommon.ValueType.String() output #6247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
update-str-type-string
branch
from
904f844
to
f22ae98
Compare
bogdandrutu
approved these changes
Oct 6, 2022
|
Please check the tests. |
dmitryax
force-pushed
the
update-str-type-string
branch
from
f22ae98
to
964d308
Compare
Codecov ReportBase: 92.22% // Head: 92.22% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6247 +/- ##
=======================================
Coverage 92.22% 92.22%
=======================================
Files 219 219
Lines 13484 13446 -38
=======================================
- Hits 12435 12401 -34
+ Misses 819 815 -4
Partials 230 230
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bogdandrutu
reviewed
Oct 6, 2022
dmitryax
force-pushed
the
update-str-type-string
branch
from
964d308
to
4bd881b
Compare
dmitryax
force-pushed
the
update-str-type-string
branch
from
4bd881b
to
6686c77
Compare
dmitryax
force-pushed
the
update-str-type-string
branch
from
6686c77
to
607322e
Compare
|
@dmitryax the issue is not resolved with this PR, see update there. |
bogdandrutu
reviewed
Oct 6, 2022
dmitryax
force-pushed
the
update-str-type-string
branch
from
607322e
to
985963e
Compare
dmitryax
changed the title
Update `pcommon.ValueType.String` output to string representation of corresponding type identifiers for consistency with other enum types
dmitryax
force-pushed
the
update-str-type-string
branch
from
985963e
to
a4d4dba
Compare
dmitryax
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we updated all names related to pdata String value. It makes sense to update string returned by Value.String accordingly to avoid discrepancy with other value types
Updates #6249