[pdata] Rename pmetric.MetricDataPointFlags to pmetric.DataPointFlags

[dmitryax]

Following pdata naming rules outlined in #6255, we want to update the struct to have the same name as defined in protobuf package.

Updates #6257

[codecov]

Codecov Report

Base: 92.30% // Head: 92.22% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (8897d20) compared to base (a3f96ff).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 8897d20 differs from pull request most recent head 15375c8. Consider uploading reports for the commit 15375c8 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6259      +/-   ##
==========================================
- Coverage   92.30%   92.22%   -0.08%     
==========================================
  Files         219      219              
  Lines       13463    13466       +3     
==========================================
- Hits        12427    12419       -8     
- Misses        806      817      +11     
  Partials      230      230              

Impacted Files	Coverage Δ
pdata/pmetric/generated_metrics.go	96.09% <100.00%> (ø)
pdata/pmetric/metric_data_point_flags.go	100.00% <100.00%> (ø)
pdata/internal/wrapper_metrics.go	52.17% <0.00%> (-47.83%)	⬇️
confmap/resolver.go	97.20% <0.00%> (-0.15%)	⬇️
pdata/plog/logs.go	96.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[bogdandrutu]

where is the DataPointFlags defined?

[dmitryax]

@bogdandrutu do you mean pdata definition? it's here https://github.com/open-telemetry/opentelemetry-collector/pull/6259/files#diff-39b6dfa0a0fdf8e13fb63075018e16a009a905cfd91c451af47768bac6268e96R23

[bogdandrutu]

As a new rule we want to rename all the structs for proto messages defined at the package level to not have the owner prefix in its name.

Read the description.

Base on what rule do you think this change should be done?

[dmitryax]

Right, the description is a bit incorrect. This is proto enum not a message https://github.com/open-telemetry/opentelemetry-proto/blob/main/opentelemetry/proto/metrics/v1/metrics.proto#L321. But I believe we should apply the same rule for enums. Do you think otherwise?

[dmitryax]

Updated the description