[pdata] Rename pmetric.Buckets to ExponentialHistogramDataPointBuckets #6261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 92.30% // Head: 92.30% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #6261 +/- ##
=======================================
Coverage 92.30% 92.30%
=======================================
Files 219 219
Lines 13455 13455
=======================================
Hits 12419 12419
Misses 806 806
Partials 230 230
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Rename `pmetric.[New]?Buckets` struct and func to align it with the underlying protobuf message. It should have `ExponentialHistogramDataPoint` prefix as it's defined in the scope of `ExponentialHistogramDataPoint` protobuf message.
dmitryax
force-pushed
the
rename-buckets
branch
from
ef74061
to
1e416a9
Compare
bogdandrutu
approved these changes
Oct 8, 2022
bogdandrutu
reviewed
Oct 10, 2022
This was referenced Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
pmetric.[New]?Bucketsstruct and func to align it with the underlying protobuf message. It should haveExponentialHistogramDataPointprefix as it's defined in the scope ofExponentialHistogramDataPointprotobuf message: https://github.com/open-telemetry/opentelemetry-proto/blob/001e5eabf3ea0193ef9343c1b9a057d23d583d7c/opentelemetry/proto/metrics/v1/metrics.proto#L533Updates #6257