Instrument exporters' obsreport with OpenTelemetry #6346
Conversation
* Allow for dual instrumentation * remove log * Add back mutators
Codecov ReportBase: 91.82% // Head: 91.89% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6346 +/- ##
==========================================
+ Coverage 91.82% 91.89% +0.07%
==========================================
Files 237 237
Lines 13549 13620 +71
==========================================
+ Hits 12441 12516 +75
+ Misses 882 874 -8
- Partials 226 230 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
obsreport/obsreport_exporter.go
Outdated
| } | ||
| meter := cfg.ExporterCreateSettings.MeterProvider.Meter(exporterScope) |
There was a problem hiding this comment.
might as well create this meter inside of the createOtelMetrics method
There was a problem hiding this comment.
In that case i'll need to pass the config down, I think that's fine.
jaronoff97
requested review from
codeboten
and removed request for
bogdandrutu
| @@ -28,6 +28,24 @@ func newStubPromChecker() prometheusChecker { | |||
| return prometheusChecker{ | |||
| promHandler: http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) { | |||
| _, _ = w.Write([]byte(` | |||
| # HELP exporter_send_failed_spans Number of spans in failed attempts to send to destination. | |||
There was a problem hiding this comment.
@paivagustavo @jaronoff97 please in a separate PR move this to a file
Description:
This PR adds OpenTelemetry instrumentation for the obsreport exporter. This closely follows the previous PR from @paivagustavo for the receiver (#6222)
Link to tracking Issue: Part of #816
Testing: This was tested by running the otel collector locally with the demo client and server. It successfully ran with the gate enabled and disabled, emitting the same metrics.