Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Remove telemetryInitializer from CollectorSettings #6728

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Dec 9, 2022

This will allow to move deprecated Collector to otelcol.

Updates #5564

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested review from a team and Aneurysm9 December 9, 2022 21:33
@bogdandrutu bogdandrutu force-pushed the mvteltests branch 4 times, most recently from 1e0ff8c to cc7b1c9 Compare December 9, 2022 23:41
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Base: 89.64% // Head: 89.64% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (8e0c43d) compared to base (40fcb05).
Patch coverage: 63.63% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6728      +/-   ##
==========================================
- Coverage   89.64%   89.64%   -0.01%     
==========================================
  Files         246      246              
  Lines       14304    14302       -2     
==========================================
- Hits        12823    12821       -2     
  Misses       1231     1231              
  Partials      250      250              
Impacted Files Coverage Δ
service/service.go 68.96% <62.50%> (-0.48%) ⬇️
service/collector.go 76.76% <66.66%> (+0.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

This will allow to move deprecated Collector to otelcol.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 8222571 into open-telemetry:main Dec 12, 2022
@bogdandrutu bogdandrutu deleted the mvteltests branch December 12, 2022 20:11
jaronoff97 pushed a commit to lightstep/opentelemetry-collector that referenced this pull request Dec 14, 2022
…metry#6728)

This will allow to move deprecated Collector to otelcol.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
jaronoff97 pushed a commit to lightstep/opentelemetry-collector that referenced this pull request Dec 14, 2022
…metry#6728)

This will allow to move deprecated Collector to otelcol.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants