Add receiver.Builder to help with creating components form a set of configs and factories #6803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
draftbuilder
branch
3 times, most recently
from
9e90c0b
to
413390d
Compare
Codecov ReportBase: 90.08% // Head: 89.90% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6803 +/- ##
==========================================
- Coverage 90.08% 89.90% -0.19%
==========================================
Files 246 248 +2
Lines 14246 14342 +96
==========================================
+ Hits 12834 12894 +60
- Misses 1163 1187 +24
- Partials 249 261 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bogdandrutu
changed the title
bogdandrutu
force-pushed
the
draftbuilder
branch
from
413390d
to
6901a8e
Compare
djaglowski
reviewed
Dec 15, 2022
bogdandrutu
force-pushed
the
draftbuilder
branch
from
6901a8e
to
2325358
Compare
dmitryax
approved these changes
Dec 15, 2022
|
And we will do that for other component types, right? |
bogdandrutu
force-pushed
the
draftbuilder
branch
2 times, most recently
from
8d9532a
to
ff525cd
Compare
|
@dmitryax @djaglowski I am not convinced about the name of the type (Builder), here are some ideas:
|
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
draftbuilder
branch
from
ff525cd
to
f15d540
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea is that we pass a
receiver.Builder(a combo of configs and factories that can create Receivers to the Service) instead of configs and factories separately. This way we help other distributions to re-implement service/host.