Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix otelcol_exporter_send_failed_requests count error #7527

Merged
merged 1 commit into from
Apr 24, 2023
Merged

fix otelcol_exporter_send_failed_requests count error #7527

merged 1 commit into from
Apr 24, 2023

Conversation

HeavenTonight
Copy link
Contributor

@HeavenTonight HeavenTonight commented Apr 12, 2023

Signed-off-by: guiyong.ou guiyong.ou@daocloud.io
Description: <Describe what has changed.
fix otelcol_exporter_send_failed_requests count error

Link to tracking Issue:
fixed #7456

@HeavenTonight HeavenTonight requested review from a team and jpkrohling April 12, 2023 10:25
@jpkrohling
Copy link
Member

jpkrohling commented Apr 13, 2023

@TylerHelmuth, you've been involved in the discussion of the original issue. Would you mind reviewing this one?

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HeavenTonight thanks for taking care of this.

.chloggen/fix-send_failed_requests-counter.yaml Outdated Show resolved Hide resolved
@TylerHelmuth
Copy link
Member

@jpkrohling can you approve the workflows? I don't have permissions in this repo.

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (27d3efb) 91.14% compared to head (abbe52c) 91.19%.

❗ Current head abbe52c differs from pull request most recent head 746473a. Consider uploading reports for the commit 746473a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7527      +/-   ##
==========================================
+ Coverage   91.14%   91.19%   +0.04%     
==========================================
  Files         295      296       +1     
  Lines       14395    14441      +46     
==========================================
+ Hits        13121    13170      +49     
+ Misses       1008     1006       -2     
+ Partials      266      265       -1     
Impacted Files Coverage Δ
obsreport/obsreport_exporter.go 96.00% <100.00%> (+0.19%) ⬆️
obsreport/obsreporttest/otelprometheuschecker.go 95.41% <100.00%> (+0.46%) ⬆️
service/telemetry.go 88.26% <100.00%> (+0.33%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

fix otelcol_exporter_send_failed_requests count error

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

test and changelog

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

fix note

fix otelcol_exporter_send_failed_requests count error

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

fix otelcol_exporter_send_failed_requests count error

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

test and changelog

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

fix otelcol_exporter_send_failed_requests count error

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

fix otelcol_exporter_send_failed_requests count error

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

test and changelog

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

fix note

fix otelcol_exporter_send_failed_requests count error

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

fix otelcol_exporter_send_failed_requests count error

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

test and changelog

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

fix note

new line

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

fix otelcol_exporter_send_failed_requests count error

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

fix otelcol_exporter_send_failed_requests count error

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

test and changelog

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

fix note

fix otelcol_exporter_send_failed_requests count error

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

fix otelcol_exporter_send_failed_requests count error

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

test and changelog

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

fix otelcol_exporter_send_failed_requests count error

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

fix otelcol_exporter_send_failed_requests count error

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

test and changelog

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

fix note

fix otelcol_exporter_send_failed_requests count error

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

fix otelcol_exporter_send_failed_requests count error

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

test and changelog

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

fix note

new line

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

new line!

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>
@codeboten codeboten merged commit 8e33ded into open-telemetry:main Apr 24, 2023
@github-actions github-actions bot added this to the next release milestone Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics send_failed_requests is inaccurate/abnormal
5 participants