[config/confighttp] Support zstd and snappy decompress #7636
Conversation
|
|
|
Please review and sign the CLA. |
|
Please make sure to link to an issue. #7632 seems related to this issue. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7636 +/- ##
==========================================
+ Coverage 91.23% 91.26% +0.03%
==========================================
Files 296 296
Lines 14473 14502 +29
==========================================
+ Hits 13204 13235 +31
+ Misses 1004 1002 -2
Partials 265 265
☔ View full report in Codecov by Sentry. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
| @@ -146,6 +147,7 @@ func (d *decompressor) wrap(h http.Handler) http.Handler { | |||
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | |||
| newBody, err := newBodyReader(r) | |||
| if err != nil { | |||
| r.Body.Close() | |||
| d.errorHandler(w, r, err.Error(), http.StatusBadRequest) | |||
| return | |||
| } | |||
There was a problem hiding this comment.
Is there not a bug at line 155? Why closing the newBody?
There was a problem hiding this comment.
Please address this comment?
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Please resolve conflicts. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
fix #7632
Description:
bug: the otlphttp exporter zstd and snappy compression is not work.
how to fix: add zstd and snappy decompress reader.